perf(controller): look up types instead of scanning the pokedex #33
+219
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Nothing imported it, so none of it was running * Its selectors and variables are vite template leftovers that no component references * Its #root block also contradicted the layout rules in App.css References #30
* Add an engines field so npm warns on an unsupported version * Add .nvmrc so nvm picks the right node automatically * Versions match what the assignment asks for, node 24.6 and npm 11 References #31
* Add getPokemonIdsByType, which returns every member of a type in one request * Walk only those ids when a type rule is set, so filling the list stops fetching every pokemon in between * Merge the ids when several types are picked, matching how matchesFilter keeps a pokemon that has any of them * Hold on to the id list per type, the members do not change while the page is open * Fall back to the old walk when no type rule is set * Add tests for the lookup and for the ids it does not fetch References #28
This was referenced Sep 17, 2026
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #28, #30 and #31.
Filtered next/prev now looks up the members of a type in one request instead of walking every id until one matches. Also deletes the unused index.css and records the node/npm versions in engines and .nvmrc.